[webkit-reviews] review granted: [Bug 42345] Web Inspector: pass all parameters to WebInspector.addConsoleMessage as a single payload object : [Attachment 61664] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 08:13:23 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 42345: Web Inspector: pass all parameters to WebInspector.addConsoleMessage
as a single payload object
https://bugs.webkit.org/show_bug.cgi?id=42345

Attachment 61664: Patch
https://bugs.webkit.org/attachment.cgi?id=61664&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/ConsoleView.js:685
 +		    this.formattedMessage = this._format(["%O",
this._parameters[0]]);
I am a bit concerned with the potential switch from <non-undefined>[0] to
<potentially-undefined>[0].


More information about the webkit-reviews mailing list