[webkit-reviews] review granted: [Bug 41845] refactor identifier parsing in lexer : [Attachment 61619] the second part again

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 41845: refactor identifier parsing in lexer
https://bugs.webkit.org/show_bug.cgi?id=41845

Attachment 61619: the second part again
https://bugs.webkit.org/attachment.cgi?id=61619&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
JavaScriptCore/parser/Lexer.cpp:353
 +	// part of an identifier. (See the CharacterType defintion for more
details.)
Typo here: "defintion".

JavaScriptCore/parser/Lexer.cpp:465
 +	    if (UNLIKELY(((static_cast<unsigned>(m_current) - 0xE) & 0x2000)))
{
The tricky expression here should be inside a named inline function to document
what it does. Even if we don't want to do that, at the very least it needs a
comment because its non-obvious. That’s not new in this patch, though.