[webkit-reviews] review denied: [Bug 42345] Web Inspector: pass all parameters to WebInspector.addConsoleMessage as a single payload object : [Attachment 61630] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 42345: Web Inspector: pass all parameters to WebInspector.addConsoleMessage
as a single payload object
https://bugs.webkit.org/show_bug.cgi?id=42345

Attachment 61630: Patch
https://bugs.webkit.org/attachment.cgi?id=61630&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/ConsoleView.js:278
 +		msgCopy = new WebInspector.ConsoleMessage(msg.source, msg.type,
msg.level, msg.line, msg.url, msg.groupLevel, count, msg.messageText,
msg.parameters, msg.stackTrace);
I think you affect the repeatCount and repeatDelta properties.

WebCore/inspector/front-end/ConsoleView.js:658
 +	this.parameters = parameters;
These should be private.



WebCore/inspector/front-end/ConsoleView.js:676
 +		    var stack = this.stackTrace.slice();
No need.