[webkit-reviews] review requested: [Bug 42240] [GTK] http/tests/media/video-cookie.html fails : [Attachment 61638] Create SoupCookieJar in tests if it does not exist when setting the accept policy

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has asked  for review:
Bug 42240: [GTK] http/tests/media/video-cookie.html fails
https://bugs.webkit.org/show_bug.cgi?id=42240

Attachment 61638: Create SoupCookieJar in tests if it does not exist when
setting the accept policy
https://bugs.webkit.org/attachment.cgi?id=61638&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
The problem was that the test was trying to set the cookie accept policy before
the SoupCookieJar was actually created. This happens because we create it on
demand, i.e the first time a http request is issued. In this test the first
request is a file:// url, that's why when the test tries to set the accept
policy it fails because there is no SoupCookieJar. After that the following
http request creates the soupcookiejar but with the default accept policy,
which is no third party. That is the reason why the test was not working

What we do now is to create the SoupCookieJar if the test requests to change
the accept policy and the jar was not yet created.