[webkit-reviews] review granted: [Bug 42339] WebKit needs a rebaselining tool (finally) : [Attachment 61612] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 14 23:58:27 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 42339: WebKit needs a rebaselining tool (finally)
https://bugs.webkit.org/show_bug.cgi?id=42339
Attachment 61612: Patch
https://bugs.webkit.org/attachment.cgi?id=61612&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok. This is a good start. We'll need to refactor this into some of the lower
layers at some point.
WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py:97
+ actual_path = test_base + "-actual.txt"
This knowledge probably shouldn't be here.
More information about the webkit-reviews
mailing list