[webkit-reviews] review granted: [Bug 42303] Backfill DNS and connect times rather than exposing hard zeros : [Attachment 61583] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 42303: Backfill DNS and connect times rather than exposing hard zeros
https://bugs.webkit.org/show_bug.cgi?id=42303

Attachment 61583: Patch
https://bugs.webkit.org/attachment.cgi?id=61583&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/page/Timing.cpp:58
 +  static unsigned long long toIntegerMilliseconds(double milliseconds)
nit: move to the top of the file so that the Timing methods are not interrupted

by a non-Timing method.  it isn't a real readability issue now, but once you
add an interrupt like this, someone will add more, and pretty soon you'll get
half of your class implemented in one section of the file and the other half
in another :(


R=me