[webkit-reviews] review requested: [Bug 37930] [Win] Implement LayoutTestController::markerTextForListItem() : [Attachment 61605] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 37930: [Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930

Attachment 61605: Patch
https://bugs.webkit.org/attachment.cgi?id=61605&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I thought to split up the Mac and Windows patches and use Bug #42054 as a meta
bug.

With insight from Adam Roben, I updated the patch based on Darin Adler's
comment in Bug #42054 <https://bugs.webkit.org/show_bug.cgi?id=42054#c4>. I
thought to keep the implementation of both ports similar for consistency. So, I
added a similar DOMElement conversion function to the Windows port,
WebFrame::elementFromJS (I am open to naming suggestions).

I was not sure where to place WebFrame::elementFromJS. My original thought was
to add a class method to DOMElement (similar to the class method added to the
WebDOMElementOperationsPrivate category of DOMElement in the Mac patch - see
bug #37929), but I felt that keeping the function in some kind of private
interface better demarcated that this function is not for public usage.

I am open to suggestions on this patch.