[webkit-reviews] review denied: [Bug 42188] Failing 2d.path.stroke.prune.arc philip canvas test : [Attachment 61589] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Matthew Delaney <mdelaney at apple.com>'s
request for review:
Bug 42188: Failing 2d.path.stroke.prune.arc philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42188

Attachment 61589: Patch
https://bugs.webkit.org/attachment.cgi?id=61589&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +FloatPoint Path::currentPoint() const 
> +{
> +    // FIXME: implement safe way to return current point of subpath.
> +    return 0;
> +}

I don’t think this will compile. There’s no way to convert the number 0 into a
FloatPoint. You probably need to return something like FloatPoint(NAN, NAN).
You should test by actually compiling the code, perhaps in PathCG.cpp.

Not sure what "safe" means in the comment.