[webkit-reviews] review granted: [Bug 42300] Canvas: Don't add shadow rect to dirty region when shadow alpha is 0 : [Attachment 61578] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 16:14:27 PDT 2010


Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 42300: Canvas: Don't add shadow rect to dirty region when shadow alpha is 0
https://bugs.webkit.org/show_bug.cgi?id=42300

Attachment 61578: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=61578&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It’s unfortunate we have to construct a Color just to check the alpha channel.
That’s going to cost some actual instructions and CPU time. Maybe we should
have more functions that operate directly on RGBA32 values.


More information about the webkit-reviews mailing list