[webkit-reviews] review granted: [Bug 42296] Add NetscapePluginStream class : [Attachment 61575] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 42296: Add NetscapePluginStream class
https://bugs.webkit.org/show_bug.cgi?id=42296

Attachment 61575: Patch
https://bugs.webkit.org/attachment.cgi?id=61575&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +NetscapePluginStream::NetscapePluginStream(NetscapePlugin* plugin, uint64_t
streamID, bool sendNotification, void* notificationData)

bool is no fun

> +    NetscapePluginStream(NetscapePlugin* plugin, uint64_t streamID, bool
sendNotification, void* notificationData);

No need for the argument name "plugin".

> +    RefPtr<NetscapePlugin> m_plugin;

If this class holds a ref to the plugin then the argument should be
PassRefPtr<NetscapePlugin>, not NetscapePlugin*.