[webkit-reviews] review denied: [Bug 42188] Failing 2d.path.stroke.prune.arc philip canvas test : [Attachment 61566] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Matthew Delaney <mdelaney at apple.com>'s
request for review:
Bug 42188: Failing 2d.path.stroke.prune.arc philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42188

Attachment 61566: Patch
https://bugs.webkit.org/attachment.cgi?id=61566&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if ((p1 == m_path.currentPoint()) || (p1 == p2) || !r)

No need for the extra parentheses here since == binds more tightly than || and
it's customary to not include these.

> Index: WebCore/platform/graphics/cg/PathCG.cpp
> ===================================================================
> --- WebCore/platform/graphics/cg/PathCG.cpp	(revision 63275)
> +++ WebCore/platform/graphics/cg/PathCG.cpp	(working copy)
> @@ -249,6 +249,11 @@ bool Path::hasCurrentPoint() const
>  {
>      return !isEmpty();
>  }
> +    
> +FloatPoint Path::currentPoint() const 
> +{
> +    return CGPathGetCurrentPoint(m_path);
> +}

I believe adding this for CG only will break the build for all platforms that
don’t use CG. That’s probably why the EWS failed on Qt. So you’ll need to add
this for other platforms as well.

review- because we need this to at least compile on the non-CG platforms