[webkit-reviews] review granted: [Bug 42282] Fix enum value names for Navigation.{idl|h} : [Attachment 61555] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 14 13:42:27 PDT 2010
Darin Adler <darin at apple.com> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 42282: Fix enum value names for Navigation.{idl|h}
https://bugs.webkit.org/show_bug.cgi?id=42282
Attachment 61555: Patch
https://bugs.webkit.org/attachment.cgi?id=61555&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + enum NavigationType {
> + NAVIGATE = 0,
> + RELOAD = 1,
> + BACK_FORWARD = 2,
> + };
I don’t think it’s important to have those "= 0", "= 1", "= 2" there.
I’m surprised this patch doesn’t remove DontCheckEnum from the IDL file.
More information about the webkit-reviews
mailing list