[webkit-reviews] review denied: [Bug 38400] [Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html : [Attachment 61513] patch4

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has denied qi <qi.2.zhang at nokia.com>'s
request for review:
Bug 38400: [Qt] Failure on
http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400

Attachment 61513: patch4
https://bugs.webkit.org/attachment.cgi?id=61513&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
>WebCore/platform/graphics/qt/GraphicsContextQt.cpp:725
> +	 QImage shadowImage(roundedIntSize(normalizedRect.size()),
QImage::Format_ARGB32_Premultiplied);
> +	 QPainter pShadow(&shadowImage);
This will add huge performance penalty to fillRect() calls where no shadow is
used.
This QImage and QPainter should only be initialized if they're actually going
to be used.

r- for this, the rest of the code is shaping up nicely.