[webkit-reviews] review requested: [Bug 42272] Canvas: Fast-path for assigning the same color string as before to fillStyle or strokeStyle : [Attachment 61541] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 11:07:34 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 42272: Canvas: Fast-path for assigning the same color string as before to
fillStyle or strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=42272

Attachment 61541: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=61541&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Benchmarking with Hixie's fillRect video test:
http://hixie.ch/tests/adhoc/perf/video/002.html

BEFORE:

Elapsed wall-clock time: 853ms (ideal: 640ms).
Elapsed non-idle time: 213ms (ideal: 0ms).
Speed: 17.58fps (ideal: 25.00fps).

AFTER:

Elapsed wall-clock time: 819ms (ideal: 640ms).
Elapsed non-idle time: 179ms (ideal: 0ms).
Speed: 18.32fps (ideal: 25.00fps).


More information about the webkit-reviews mailing list