[webkit-reviews] review granted: [Bug 42201] Use ResourceHandle object for synchronous loading : [Attachment 61452] updated patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 42201: Use ResourceHandle object for synchronous loading
https://bugs.webkit.org/show_bug.cgi?id=42201

Attachment 61452: updated patch
https://bugs.webkit.org/attachment.cgi?id=61452&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
In some other code we use originalRequest rather than firstRequest. Is this the
same concept?

> +    void setAllowStoredCredentials(bool allow) { m_allowStoredCredentials =
allow; }
> +    bool isDone() { return m_isDone; }
> +
> +    CFMutableDataRef data() { return m_data.get(); }
> +
> +    virtual void willSendRequest(ResourceHandle*, ResourceRequest&, const
ResourceResponse& /*redirectResponse*/);
> +    virtual bool shouldUseCredentialStorage(ResourceHandle*);
> +    virtual void didReceiveAuthenticationChallenge(ResourceHandle*, const
AuthenticationChallenge&);
> +    virtual void didReceiveResponse(ResourceHandle*, const
ResourceResponse&);
> +    virtual void didReceiveData(ResourceHandle*, const char*, int, int
/*lengthReceived*/);
> +    virtual void didFinishLoading(ResourceHandle*);
> +    virtual void didFail(ResourceHandle*, const ResourceError&);
> +#if USE(PROTECTION_SPACE_AUTH_CALLBACK)
> +    virtual bool canAuthenticateAgainstProtectionSpace(ResourceHandle*,
const ProtectionSpace&);
> +#endif

Can any of these be private?

Looks like a compile failure on GTK.