[webkit-reviews] review granted: [Bug 42117] AX: Data table heuristics: consider assuming data table for 'zebra-striped' rows : [Attachment 61281] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 42117: AX: Data table heuristics: consider assuming data table for
'zebra-striped' rows
https://bugs.webkit.org/show_bug.cgi?id=42117

Attachment 61281: Patch
https://bugs.webkit.org/attachment.cgi?id=61281&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       // For the first 5 rows, cache the background color so we can
check if this table has zebra-striped rows.
> +	       if (row < 5 && row == (int)alternatingColorCache.size()) {

If you have to do type casting, you should do a C++ cast, not C.

> +		   alternatingColorCache.append(rowColor);

I'm not sure "cache" is the right name for this data structure. I'd just call
it rowColors.

Code seems OK, I’ll say r=me