[webkit-reviews] review denied: [Bug 42250] Code generator: ensure generated constants match their corresponding enums. : [Attachment 61523] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 08:40:39 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 42250: Code generator: ensure generated constants match their corresponding
enums.
https://bugs.webkit.org/show_bug.cgi?id=42250

Attachment 61523: Patch
https://bugs.webkit.org/attachment.cgi?id=61523&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/dom/OverflowEvent.idl:26
 +	# FIXME: Remove DontCheckEnums attribute.
Remove it when?

WebCore/svg/SVGGradientElement.idl:28
 +	interface [Conditional=SVG, DontCheckEnums] SVGGradientElement :
SVGElement,
Do wrapping like some of the earlier interfaces in this file.



close


More information about the webkit-reviews mailing list