[webkit-reviews] review requested: [Bug 42258] Improve coverage of fast/dom/Window/window-properties test : [Attachment 61516] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 07:27:09 PDT 2010


Kent Hansen <kent.hansen at nokia.com> has asked  for review:
Bug 42258: Improve coverage of fast/dom/Window/window-properties test
https://bugs.webkit.org/show_bug.cgi?id=42258

Attachment 61516: Patch
https://bugs.webkit.org/attachment.cgi?id=61516&action=review

------- Additional Comments from Kent Hansen <kent.hansen at nokia.com>
Introduces a helper function, propertiesOnObject(), to compute an object's
properties. Properties in the prototype chain are added as well, to correspond
with for..in behavior. However, it stops at the built-in prototypes to avoid
spewing out a bunch of "redundant" properties (e.g. including properties from
Object.prototype for every visited object blows up the expected results
immensely).

I've updated the gtk results even though this test is currently skipped on that
platform (https://bugs.webkit.org/show_bug.cgi?id=30594).


More information about the webkit-reviews mailing list