[webkit-reviews] review denied: [Bug 42250] Code generator: ensure generated constants match their corresponding enums. : [Attachment 61507] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 42250: Code generator: ensure generated constants match their corresponding
enums.
https://bugs.webkit.org/show_bug.cgi?id=42250

Attachment 61507: Patch
https://bugs.webkit.org/attachment.cgi?id=61507&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/bindings/scripts/CodeGeneratorV8.pm:1549
 +  sub shouldCheckEnum
We should add a new attribute to these classes in their IDLs rather than adding
stuff to the code generator, I think.

I think I like that we're black listing (rather than white listing) though. 
That way people adding constants in the future will need to opt out rather than
in.