[webkit-reviews] review denied: [Bug 42210] [chromium] Autofill menu shows seperator at the wrong place when an entry is deleted : [Attachment 61430] Initial fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 23:02:47 PDT 2010


David Levin <levin at chromium.org> has denied Scott Violet <sky at google.com>'s
request for review:
Bug 42210: [chromium] Autofill menu shows seperator at the wrong place when an
entry is deleted
https://bugs.webkit.org/show_bug.cgi?id=42210

Attachment 61430: Initial fix
https://bugs.webkit.org/attachment.cgi?id=61430&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: ChangeLog
> +	   * ../../WebKit/chromium/src/AutoFillPopupMenuClient.cpp:
>
A few probloems:
1. The is either the wrong ChangeLog or else this patch is malformed. It should
be the ChangeLog at WebKit/chromium/ChangeLog.
2. The path in the ChangeLog is messed up.
3. The function being modified is missing in the ChangeLog.
My bad if I missed any of these things before.


Lastly,it is nice to give a *small* comment by the function in the ChangeLog to
explain what was done. (It looks like the change involves account for the
separator index.)


More information about the webkit-reviews mailing list