[webkit-reviews] review requested: [Bug 40058] testapi.c depends on the Core Foundation. : [Attachment 61470] Separate CF parts of testapi, compile support for Qt environment, take 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 22:26:16 PDT 2010


Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org> has asked	for
review:
Bug 40058: testapi.c depends on the Core Foundation.
https://bugs.webkit.org/show_bug.cgi?id=40058

Attachment 61470: Separate CF parts of testapi, compile support for Qt
environment, take 3
https://bugs.webkit.org/attachment.cgi?id=61470&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>
The original commit was rolled out because it broke Win compilation (bug
42229). In VCProj, config.h wasn't available in the testapi utility
compilation. Sorry folks.

The patch is the same as before, but adds the necessary bits for the Win build
system (at least what I thought was necessary). Any suggestions on how to do it
better is appreciated, since I'm not familiar with VCProj neiter have a win
system available.

I'm marking this for review? but not cq? so the bots can check this patch and
we can see if win passes. I will also remove the r? from the other patch to
avoid confusion.


More information about the webkit-reviews mailing list