[webkit-reviews] review granted: [Bug 42230] Page flashes to mostly white towards the end of loading : [Attachment 61466] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 21:54:47 PDT 2010


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 42230: Page flashes to mostly white towards the end of loading
https://bugs.webkit.org/show_bug.cgi?id=42230

Attachment 61466: Patch
https://bugs.webkit.org/attachment.cgi?id=61466&action=review

------- Additional Comments from mitz at webkit.org
> +	   as the dimensions, to ensure the layer appers on the correct place.

Typo: “appers on”

> +    FloatSize usedSize = m_size;
> +    if (m_usingTiledLayer)
> +	   usedSize = constrainedSize();

I’d write this as
    FloatSize usedSize = m_usingTiledLayer ? constrainedSize() : m_size;
but the compiler probably doesn’t care.

r=me!


More information about the webkit-reviews mailing list