[webkit-reviews] review granted: [Bug 42189] Failing 2d.path.stroke.prune.line philip canvas test : [Attachment 61461] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 20:20:53 PDT 2010


Adele Peterson <adele at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 42189: Failing 2d.path.stroke.prune.line philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42189

Attachment 61461: Patch
https://bugs.webkit.org/attachment.cgi?id=61461&action=review

------- Additional Comments from Adele Peterson <adele at apple.com>
Looks good.  The local variable should get a more meaningful name - like
"path".  There are a bunch of "p"s and "cp"s in this file, so you don't have to
fix those, but since you're adding a new one, you might as well give it a good
name.

r=me!  Do you want to use the commit-queue for this?


More information about the webkit-reviews mailing list