[webkit-reviews] review denied: [Bug 40872] experimental directory upload : [Attachment 61254] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 13 18:23:11 PDT 2010
Jian Li <jianli at chromium.org> has denied John Gregg <johnnyg at google.com>'s
request for review:
Bug 40872: experimental directory upload
https://bugs.webkit.org/show_bug.cgi?id=40872
Attachment 61254: Patch
https://bugs.webkit.org/attachment.cgi?id=61254&action=review
------- Additional Comments from Jian Li <jianli at chromium.org>
I only see the file "mac/Skipped", not other Skipped files. By the way, have
you also tested it on the chromium platform?
LayoutTests/ChangeLog:5
+ Unit test for experimental directory upload feature. Only enabled
on chromium since that's where the feature is compiled in.
Please remove "Unit" since this is not called unit test in WebKit.
LayoutTests/fast/forms/input-file-directory-upload.html:8
+ var currentFileList_;
Please do not add the trailing "_" for the variable.
LayoutTests/fast/forms/input-file-directory-upload.html:9
+ var lastTest_ = false;
ditto.
LayoutTests/fast/forms/input-file-directory-upload.html:60
+ currentFileList_ = fileList;
Is it possible to avoid using global variables?
Also, is there any possibility we have some sort of indeterminism here? What I
mean is that: do we always execute the JS code in the following order:
doTest(testFileList1)
onInputFileChange
doTest(testFileList2)
onInputFileChange
...
More information about the webkit-reviews
mailing list