[webkit-reviews] review requested: [Bug 41920] Avoid slow-path for put() in Array.splice() : [Attachment 61424] Proposed patch v5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 13 15:37:14 PDT 2010
Andreas Kling <andreas.kling at nokia.com> has asked for review:
Bug 41920: Avoid slow-path for put() in Array.splice()
https://bugs.webkit.org/show_bug.cgi?id=41920
Attachment 61424: Proposed patch v5
https://bugs.webkit.org/attachment.cgi?id=61424&action=review
------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Updated patch, sorry about the delay!
* Brief explanation about CreateCompact mode added to JSArray.h
* m_inCompactInitialization flag added to ArrayStorage (only with
CHECK_ARRAY_CONSISTENCY)
* ASSERT(m_inCompactInitialization) added to uncheckedSetIndex()
* setLength() won't call checkConsistency() on entry at the first call after
CreateCompact initialization.
More information about the webkit-reviews
mailing list