[webkit-reviews] review granted: [Bug 42178] Update media element's seeking logic : [Attachment 61416] proposed patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 42178: Update media element's seeking logic
https://bugs.webkit.org/show_bug.cgi?id=42178

Attachment 61416: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=61416&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (abs(startTime - time) < closest)
> +	       closest = abs(startTime - time);
> +	   else if (abs(endTime - time) < closest)
> +	       closest = abs(endTime - time);

The function used here should be fabsf, not abs. Calling abs converts the
number to an int!

Also, I am concerned about the ignored ExceptionCode. Why is it OK to ignore
it? Can there be an exception.

r=me but please fix that fabsf thing