[webkit-reviews] review denied: [Bug 40209] [GTK] Enabling File Reader/Writer APIs : [Attachment 61351] Fixed style error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 15:11:35 PDT 2010


Jian Li <jianli at chromium.org> has denied Joone Hur <joone at kldp.org>'s request
for review:
Bug 40209: [GTK] Enabling File Reader/Writer APIs
https://bugs.webkit.org/show_bug.cgi?id=40209

Attachment 61351: Fixed style error
https://bugs.webkit.org/attachment.cgi?id=61351&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Generally looks good except one minor comment:

WebCore/ChangeLog:8
 +	    No new tests, it needs to include fast/files test case.
This comment is a little bit confusing. Better to say the layout test
fast/files will be enabled after eventSender.beginDragWithFiles is implemented
for GTK.

By the way, do you want to land your patch via commit-queue after it is
approved? If yes, please set commit-queue flag to "?".


More information about the webkit-reviews mailing list