[webkit-reviews] review granted: [Bug 40932] Separate line-ending conversion code from BlobItem for code cleanup : [Attachment 61139] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has granted Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 40932: Separate line-ending conversion code from BlobItem for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=40932

Attachment 61139: Patch
https://bugs.webkit.org/attachment.cgi?id=61139&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
r=me

Looks good except the following minor comments. Please address these issue
before you land the patch.

WebCore/platform/text/LineEnding.h:38
 +  using WTF::CString;
Please try to avoid using "using" directive in the header file if possible.

WebCore/platform/text/LineEnding.h:51
 +  // Normalize all line-endings in the given string to the native
line-endings
Please end the comment with period.

WebCore/platform/text/LineEnding.h:52
 +  // (e.g. normalize to CRLF on Windows etc).
Better to also mention that we normalize to LF for all other platforms,
including Linux and MacOSX.