[webkit-reviews] review canceled: [Bug 41954] [Qt] GraphicsLayerQt must have syncCompositingStateForThisLayerOnly() implemented : [Attachment 61410] Patch

[bugzilla-daemon at webkit.org]

Jesus Sanchez-Palencia <jesus at webkit.org> has canceled Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 41954: [Qt] GraphicsLayerQt must have
syncCompositingStateForThisLayerOnly() implemented
https://bugs.webkit.org/show_bug.cgi?id=41954

Attachment 61410: Patch
https://bugs.webkit.org/attachment.cgi?id=61410&action=review

------- Additional Comments from Jesus Sanchez-Palencia <jesus at webkit.org>
I'm not going to ask for review it.

No'am, could you please take a look at this follow-up patch? I'm addressing
your last comments with a few exceptions.

I noticed that modifying GraphicsLayerQtImpl::recache(), 
GraphicsLayerQtImpl::notifySyncRequired() and
GraphicsLayerQt::setContentsToImage() leaves Accelerated Compositing with a
strange behavior, crashing often and not working on some examples (i.e.g.:
falling leaves).

It would help to have more info on whether a function should use the synced
state or the non-synced one. Maybe I missed something...

thanks in advance!