[webkit-reviews] review granted: [Bug 41925] [Chromium] Linux implementation of <input type=number> UI : [Attachment 61352] Patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 10:01:06 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 41925: [Chromium] Linux implementation of <input type=number> UI
https://bugs.webkit.org/show_bug.cgi?id=41925

Attachment 61352: Patch 3
https://bugs.webkit.org/attachment.cgi?id=61352&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/platform/chromium/PlatformThemeChromiumGtk.h:52
 +	enum ArrowDirection {
nit: usually ideal style-wise to put enum declarations at the top of the
public section with a new line separating it from the methods.

WebCore/platform/chromium/PlatformThemeChromiumGtk.h:68
 +  }
} // namespace WebCore

WebCore/platform/chromium/PlatformThemeChromiumGtk.cpp:220
 +  }
} // namespace WebCore


More information about the webkit-reviews mailing list