[webkit-reviews] review granted: [Bug 42163] Add tests to check if WebSocket's challenge value is random : [Attachment 61368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 09:42:41 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 42163: Add tests to check if WebSocket's challenge value is random
https://bugs.webkit.org/show_bug.cgi?id=42163

Attachment 61368: Patch
https://bugs.webkit.org/attachment.cgi?id=61368&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that requiring strict comparison is formally correct. Is there
anything in specs that disallows MessageEvent.data return a String object?

r=me, since it's at least testing for our current behavior, and the behavior is
unlikely to change.


More information about the webkit-reviews mailing list