[webkit-reviews] review denied: [Bug 42161] Removes cycles caused by "m_this" members in a few IndexedDB classes. : [Attachment 61371] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 42161: Removes cycles caused by "m_this" members in a few IndexedDB
classes.
https://bugs.webkit.org/show_bug.cgi?id=42161

Attachment 61371: Patch
https://bugs.webkit.org/attachment.cgi?id=61371&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/storage/IDBAny.h:47
 +	// Only valid with T accepted by set().
I'd lean towards leaving this comment out.  I think it's pretty clear from the
code.

WebCore/storage/IDBAny.h:49
 +	static PassRefPtr<IDBAny> create(PassRefPtr<T> idbObject)
I think it'd be slightly cleaner if you took in a raw pointer and created the
passRefPtr in this method.  That way we don't have all the redundant data
scattered through the rest of the file.