[webkit-reviews] review canceled: [Bug 42161] Removes cycles caused by "m_this" members in a few IndexedDB classes. : [Attachment 61364] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 06:17:34 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has canceled Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 42161: Removes cycles caused by "m_this" members in a few IndexedDB
classes.
https://bugs.webkit.org/show_bug.cgi?id=42161

Attachment 61364: Patch
https://bugs.webkit.org/attachment.cgi?id=61364&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/storage/IDBAny.h:46
 +	static PassRefPtr<IDBAny> create();
Do we still need this?

WebCore/storage/IDBAny.cpp:40
 +  static PassRefPtr<IDBAny> createIDBAny(PassRefPtr<T> idbType)
Hm...it seems like you could have just added the template function to the
IDBAny.h if you wanted...right?


More information about the webkit-reviews mailing list