[webkit-reviews] review denied: [Bug 42157] [v8] Web Inspector: inspector front-end crashes upon JS exception in front-end callbacks : [Attachment 61359] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 13 05:52:23 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 42157: [v8] Web Inspector: inspector front-end crashes upon JS exception in
front-end callbacks
https://bugs.webkit.org/show_bug.cgi?id=42157
Attachment 61359: patch
https://bugs.webkit.org/attachment.cgi?id=61359&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebKit/chromium/src/WebDevToolsFrontendImpl.cpp:179
+ if (tryCatch.HasCaught()) {
You don't need this, just calling tryCatch.SetVerbose(true) should be enough.
More information about the webkit-reviews
mailing list