[webkit-reviews] review granted: [Bug 42153] Activate test fonts for layout tests in WebKitTestRunner (on Mac) : [Attachment 61348] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 13 02:59:47 PDT 2010
Nikolas Zimmermann <zimmermann at kde.org> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 42153: Activate test fonts for layout tests in WebKitTestRunner (on Mac)
https://bugs.webkit.org/show_bug.cgi?id=42153
Attachment 61348: Patch
https://bugs.webkit.org/attachment.cgi?id=61348&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
WebKitTools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:28
+ #import <CoreFoundation/CoreFoundation.h>
Can you sort the headers, or did you use this order on purpose?
WebKitTools/WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:32
+ // not implemented
I'd prefer "// FIXME: Not implemented.".
Other than that, looks fine. r=me.
More information about the webkit-reviews
mailing list