[webkit-reviews] review denied: [Bug 41925] [Chromium] Linux implementation of <input type=number> UI : [Attachment 61204] Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 22:43:22 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 41925: [Chromium] Linux implementation of <input type=number> UI
https://bugs.webkit.org/show_bug.cgi?id=41925
Attachment 61204: Patch 2
https://bugs.webkit.org/attachment.cgi?id=61204&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:90
+ paint.setColor(RenderThemeChromiumLinux::saturateAndBrighten(trackHSV,
0, 0));
code in platform/ should not depend on code in rendering/.
that's a layering violation. it seems like you should
refactor this so that there is another file in platform/chromium/
that defines the shared theme code.
More information about the webkit-reviews
mailing list