[webkit-reviews] review granted: [Bug 41824] Wire network times from ResourceLoadTiming to performance.timing : [Attachment 61320] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 12 22:05:22 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 41824: Wire network times from ResourceLoadTiming to performance.timing
https://bugs.webkit.org/show_bug.cgi?id=41824

Attachment 61320: Patch
https://bugs.webkit.org/attachment.cgi?id=61320&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/page/Timing.cpp:84
 +	return static_cast<unsigned long long>(domainLookupStart * 1000);
nit: use 1000.0 to improve readability (same nit applies elsewhere).  a
static helper function might also be nice: toIntegerMilliseconds(double)?

R=me


More information about the webkit-reviews mailing list