[webkit-reviews] review granted: [Bug 42132] Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it) : [Attachment 61316] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 20:01:46 PDT 2010
Sam Weinig <sam at webkit.org> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 42132: Need support for a WebKit2-specific Skipped list (and initially add
accessibility tests to it)
https://bugs.webkit.org/show_bug.cgi?id=42132
Attachment 61316: Patch
https://bugs.webkit.org/attachment.cgi?id=61316&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
>
> +if ($useWebKitTestRunner) {
> + if (isAppleMacWebKit()) {
> + $realPlatform = $platform;
> + $platform = "mac-wk2";
> + }
> +}
Looks like a case of the "tabs." There are a few others of these.
> +# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +#
> +
> +# <https://bugs.webkit.org/show_bug.cgi?id=42130> WebKit2 needs to support
accessibility
> +# <https://bugs.webkit.org/show_bug.cgi?id=42131> WebKitTestRunner needs to
support accessibility-related DRT APIs
> +accessibility
> \ No newline at end of file
Need a newline.
Other than that, r=me.
More information about the webkit-reviews
mailing list