[webkit-reviews] review requested: [Bug 41920] Avoid slow-path for put() in Array.splice() : [Attachment 61299] Proposed patch v4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 17:28:39 PDT 2010
Andreas Kling <andreas.kling at nokia.com> has asked for review:
Bug 41920: Avoid slow-path for put() in Array.splice()
https://bugs.webkit.org/show_bug.cgi?id=41920
Attachment 61299: Proposed patch v4
https://bugs.webkit.org/attachment.cgi?id=61299&action=review
------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Patch updated addressing Darin and Oliver's comments.
* ArrayCreationMode enum moved into JSC namespace. [Darin]
* Assertion added to uncheckedSetIndex(). [Darin]
* For CreateCompact, m_storage->m_length is left as 0 and finally set by
setLength() after inserting the values. [Oliver]
More information about the webkit-reviews
mailing list