[webkit-reviews] review requested: [Bug 41920] Avoid slow-path for put() in Array.splice() : [Attachment 61290] Proposed patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 16:42:21 PDT 2010
Andreas Kling <andreas.kling at nokia.com> has asked for review:
Bug 41920: Avoid slow-path for put() in Array.splice()
https://bugs.webkit.org/show_bug.cgi?id=41920
Attachment 61290: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=61290&action=review
------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Updated to address Darin's comments.
* Replaced constructor bool parameter with enum ArrayCreationMode {
CreateCompactUninitialized, CreateInitialized }
* Added JSArray::uncheckedSetIndex(unsigned i, JSValue v)
I don't understand how we should initialize this array without looping though.
More information about the webkit-reviews
mailing list