[webkit-reviews] review denied: [Bug 42102] Moving BOM stripping from JSC specific code to V8+JSC shared code caused V8 crashes : [Attachment 61275] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 15:26:27 PDT 2010
Oliver Hunt <oliver at apple.com> has denied Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 42102: Moving BOM stripping from JSC specific code to V8+JSC shared code
caused V8 crashes
https://bugs.webkit.org/show_bug.cgi?id=42102
Attachment 61275: Patch
https://bugs.webkit.org/attachment.cgi?id=61275&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
How is v8 getting the text without boms removed? this patch basically makes it
so that decoded script data has the BOMs removed. If V8 is getting scripts
from webcore without decoding occuring then v8 is breaking itself.
That said the guard should be USE(JSC) not "WTF_USE_JSC"
More information about the webkit-reviews
mailing list