[webkit-reviews] review denied: [Bug 41384] Allow Chromium access to Select control choices : [Attachment 61270] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied George Yakovlev
<georgey at chromium.org>'s request for review:
Bug 41384: Allow Chromium access to Select control choices
https://bugs.webkit.org/show_bug.cgi?id=41384

Attachment 61270: Patch
https://bugs.webkit.org/attachment.cgi?id=61270&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebSelectElement.cpp:59
 +	  if (sourceItems[i]->hasLocalName(HTMLNames::optionTag))
^^^ indentation is wrong here and on the next line


Since the WebSelectElement::listItems method is only returning the
options contained in the SELECT element (excluding other types of
elements), I think it would be better to call this method "options":

  WebVector<WebOptionElement> WebSelectElement::options()

If someone wanted to expose the full set of list items, then that
method could return a vector of WebElement and be named listItems.


LGTM with that change.