[webkit-reviews] review denied: [Bug 41384] Allow Chromium access to Select control choices : [Attachment 61261] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 14:13:49 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied George Yakovlev
<georgey at chromium.org>'s request for review:
Bug 41384: Allow Chromium access to Select control choices
https://bugs.webkit.org/show_bug.cgi?id=41384
Attachment 61261: Patch
https://bugs.webkit.org/attachment.cgi?id=61261&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebOptionElement.h:64
+ WEBKIT_API bool disabled() const;
previously, i suggested that you rename disabled to isEnabled, flipping
the sense, to be consistent with WebFormControlElement::isEnabled. any
reason not to do this?
More information about the webkit-reviews
mailing list