[webkit-reviews] review granted: [Bug 42096] HTMLTreeBuilder needs to support mixing SVG and MathML content : [Attachment 61249] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 13:31:48 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 42096: HTMLTreeBuilder needs to support mixing SVG and MathML content
https://bugs.webkit.org/show_bug.cgi?id=42096
Attachment 61249: Patch
https://bugs.webkit.org/attachment.cgi?id=61249&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/html/HTMLTreeBuilder.cpp:1161
+ return (token.name() != MathMLNames::mglyphTag
Why ( .. ) ? We don't need those in C++.
WebCore/html/HTMLTreeBuilder.cpp:1489
+ // FIXME: We're missing a bunch of if branches here.
I'd remove this comment.
More information about the webkit-reviews
mailing list