[webkit-reviews] review denied: [Bug 42092] [Chromium] Fix adoptRef usage violation in WebAccessibilityCacheImpl.cpp : [Attachment 61246] Patch for adoptRef.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 12:58:04 PDT 2010
Darin Adler <darin at apple.com> has denied chris.guillory at google.com's request
for review:
Bug 42092: [Chromium] Fix adoptRef usage violation in
WebAccessibilityCacheImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=42092
Attachment 61246: Patch for adoptRef.
https://bugs.webkit.org/attachment.cgi?id=61246&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + // We pass a reference to this object before it can be adopted.
> + relaxAdoptionRequirement();
> m_object->setWrapper(this);
This is not the correct way to fix this problem. Instead the call to setWrapper
should be moved into the create function.
More information about the webkit-reviews
mailing list