[webkit-reviews] review granted: [Bug 42091] Web Inspector: provide starts and ends for network phases instead of duration. : [Attachment 61242] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 42091: Web Inspector: provide starts and ends for network phases instead of
duration.
https://bugs.webkit.org/show_bug.cgi?id=42091

Attachment 61242: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=61242&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This looks good. Thanks for the IRC explanation of the m_cached in
updateResponse.

>  private:
> +	   , receiveHeadersStart(0)
> +	   , receiveHeadersEnd(0)
> +	   , sslStart(-1)
> +	   , sslEnd(-1)

I know the old code had -1.0 and 0.0. It might
be clearer if -1 was given a constant. "NoValue"
or something. But I'm perfectly fine with -1, as
that is what the old code had.