[webkit-reviews] review denied: [Bug 27411] [GTK] Clipboard data is lost on exit : [Attachment 61225] Sets gtk_clipboard_set_can_store when clipboard is acquired to fix bug #27411: clipboard lost on exit.

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sarah Strong
<sarah.e.strong at gmail.com>'s request for review:
Bug 27411: [GTK] Clipboard data is lost on exit
https://bugs.webkit.org/show_bug.cgi?id=27411

Attachment 61225: Sets gtk_clipboard_set_can_store when clipboard is acquired
to fix bug #27411: clipboard lost on exit.
https://bugs.webkit.org/attachment.cgi?id=61225&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebKit/gtk/webkit/webkitwebview.cpp:3565
 +							  NULL, 0);
Two things: no need to break the line here, in WebKit code we're used to longer
lines, and this makes a bit more readable. Also, the style guidelines say we
should use 0 instead of NULL (though we do use NULL in a few cases we get
warnings otherwise).

As for the content, it looks sane to me, but I'd like to hear mrobinson's
opinion as well, since he's the one who's been working on clipboard/dragndrop
the most recently (I'll poke him). Also, we might also want to save the PRIMARY
clipboard, right? I'll say r- for now, because we need a ChangeLog entry. I
assume you are not a committer, so you may want to set commit-queue to ? as
well, so that the person who reviews your patch can make the patch be automatic
committed for you =).