[webkit-reviews] review granted: [Bug 41958] [Chromium] Crash when stepping on a breakpoint while debugging Web Inspector : [Attachment 61220] [PATCH] Use Vector instead of std::stack

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 12 06:34:18 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 41958: [Chromium] Crash when stepping on a breakpoint while debugging Web
Inspector
https://bugs.webkit.org/show_bug.cgi?id=41958

Attachment 61220: [PATCH] Use Vector instead of std::stack
https://bugs.webkit.org/attachment.cgi?id=61220&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebKit/chromium/src/WebViewImpl.cpp:194
 +	   
pageGroupLoadDeferrerStack.append(static_cast<PageGroupLoadDeferrer*>(0));
This cast is weird.

WebKit/chromium/src/WebViewImpl.cpp:206
 +	if (pageGroupLoadDeferrer)
You don't need this check.


More information about the webkit-reviews mailing list