[webkit-reviews] review denied: [Bug 41964] [chromium] popup menu should have the capability of showing labels : [Attachment 61115] Fixed style issues

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 41964: [chromium] popup menu should have the capability of showing labels
https://bugs.webkit.org/show_bug.cgi?id=41964

Attachment 61115: Fixed style issues
https://bugs.webkit.org/attachment.cgi?id=61115&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
The code looks OK.  Please fix the build error:

/Users/eseidel/Projects/MacEWS/WebKitBuild/WebCore.build/Release/WebCore.build/
Objects-normal/i386/RenderTextControlSingleLine.o
cc1plus: warnings being treated as errors
/Users/eseidel/Projects/MacEWS/WebCore/rendering/RenderTextControlSingleLine.cp
p:879: warning: unused parameter 'listIndex'
distcc[99406] ERROR: compile
/Users/eseidel/Projects/MacEWS/WebCore/rendering/RenderTextControlSingleLine.cp
p on localhost failed


WebCore/platform/chromium/PopupMenuChromium.cpp:73
 +  static const int kTextToLabelPadding = 10;
nit: We don't prepend 'k' prefix to constant value symbols.  This change is ok
for consistency.