[webkit-reviews] review denied: [Bug 41930] [QT] QtWebKit doesn't build in debug on Windows : [Attachment 61018] fixes build issue

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 41930: [QT] QtWebKit doesn't build in debug on Windows
https://bugs.webkit.org/show_bug.cgi?id=41930

Attachment 61018: fixes build issue
https://bugs.webkit.org/attachment.cgi?id=61018&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
If you look at mkspecs/win32*/qmake.conf in Qt, then you can see that we use
INCREMENTAL:NO for release builds:

QMAKE_LFLAGS_RELEASE	= /INCREMENTAL:NO

I think a cleaner fix would be to use either
QMAKE_LFLAGS_DEBUG +=
or at the very least add a comment in the .pro file what exactly this magic
line tries to achieve.

For example:

# Release builds disable incremental
# linking. Disable it also for debug
# builds because WebKit is so big
# that the linker fails to link
# incrementally in debug builds.
QMAKE_LFLAGS_DEBUG += /INCREMENTAL:NO